fix: local development fixes for skill-bundler branch#33560
Closed
hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
Closed
fix: local development fixes for skill-bundler branch#33560hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
Conversation
1. trust_env=False for httpx calls to plugin daemon - Fixes connection issues when running from source on macOS 2. Remove invalid base_path parameter from compile_one calls - The method signature doesn't include base_path parameter
hikariming
requested review from
Mairuis,
Nov1c444,
Stream29 and
Yeuoly
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes two issues found when testing the skill-bundler branch locally:
1. trust_env=False for httpx calls
api/core/plugin/impl/base.py2. Remove invalid base_path parameter
api/core/workflow/nodes/llm/node.pycompile_one()method doesn't havebase_pathparameter in its signatureTesting
Tested locally with:
Related: #33558