Skip to content

chore: workspace lint#35331

Merged
hyoban merged 14 commits intomainfrom
4-16-workspace-lint
Apr 16, 2026
Merged

chore: workspace lint#35331
hyoban merged 14 commits intomainfrom
4-16-workspace-lint

Conversation

@hyoban
Copy link
Copy Markdown
Member

@hyoban hyoban commented Apr 16, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

close #34640

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@github-actions github-actions bot added the web This relates to changes on the web. label Apr 16, 2026
@hyoban hyoban marked this pull request as ready for review April 16, 2026 16:03
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code labels Apr 16, 2026
lyzno1
lyzno1 previously approved these changes Apr 16, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.07%. Comparing base (4289cb2) to head (8890f2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35331      +/-   ##
==========================================
- Coverage   85.07%   85.07%   -0.01%     
==========================================
  Files        4396     4396              
  Lines      201656   201656              
  Branches    38321    38321              
==========================================
- Hits       171551   171550       -1     
- Misses      27002    27003       +1     
  Partials     3103     3103              
Flag Coverage Δ
web 86.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lyzno1
lyzno1 previously approved these changes Apr 16, 2026
@hyoban hyoban enabled auto-merge April 16, 2026 16:22
@hyoban hyoban added this pull request to the merge queue Apr 16, 2026
@hyoban hyoban removed this pull request from the merge queue due to a manual request Apr 16, 2026
@hyoban hyoban marked this pull request as draft April 16, 2026 16:33
@hyoban hyoban marked this pull request as ready for review April 16, 2026 16:36
lyzno1
lyzno1 previously approved these changes Apr 16, 2026
@hyoban hyoban enabled auto-merge April 16, 2026 16:40
@hyoban hyoban added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 40e040c Apr 16, 2026
35 checks passed
@hyoban hyoban deleted the 4-16-workspace-lint branch April 16, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor/Chore] Move some tools to the workspace level

2 participants