Skip to content

chore: lint dify ui with react config#35372

Draft
hyoban wants to merge 5 commits intomainfrom
4-17-lint-config-for-react
Draft

chore: lint dify ui with react config#35372
hyoban wants to merge 5 commits intomainfrom
4-17-lint-config-for-react

Conversation

@hyoban
Copy link
Copy Markdown
Member

@hyoban hyoban commented Apr 17, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Follow #35331

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 17, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Apr 17, 2026
@dosubot dosubot bot added javascript Pull requests that update javascript code refactor labels Apr 17, 2026
lyzno1
lyzno1 previously approved these changes Apr 17, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2026
@hyoban hyoban force-pushed the 4-17-lint-config-for-react branch from aebd5ed to 81bf42b Compare April 17, 2026 14:19
@hyoban hyoban force-pushed the 4-17-lint-config-for-react branch from 81bf42b to 4dae959 Compare April 17, 2026 14:21
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 17, 2026
lyzno1
lyzno1 previously approved these changes Apr 17, 2026
@hyoban hyoban enabled auto-merge April 17, 2026 14:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.43%. Comparing base (ae9c424) to head (66c9160).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35372      +/-   ##
==========================================
- Coverage   85.43%   85.43%   -0.01%     
==========================================
  Files        4431     4431              
  Lines      206705   206701       -4     
  Branches    38471    38470       -1     
==========================================
- Hits       176601   176597       -4     
  Misses      26995    26995              
  Partials     3109     3109              
Flag Coverage Δ
dify-ui 92.85% <100.00%> (ø)
web 86.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyoban hyoban added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@hyoban hyoban added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
lyzno1
lyzno1 previously approved these changes Apr 17, 2026
@hyoban hyoban enabled auto-merge April 17, 2026 16:16
@hyoban hyoban added this pull request to the merge queue Apr 17, 2026
@hyoban hyoban removed this pull request from the merge queue due to a manual request Apr 17, 2026
@hyoban hyoban enabled auto-merge April 17, 2026 16:27
@hyoban hyoban added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@lyzno1 lyzno1 enabled auto-merge April 18, 2026 07:28
lyzno1
lyzno1 previously approved these changes Apr 18, 2026
@hyoban hyoban disabled auto-merge April 18, 2026 07:29
@hyoban hyoban marked this pull request as draft April 18, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants