fix: knowledge hit-testing render failed.#36106
Merged
Merged
Conversation
…m service including remote template service and database, return responding error message.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…m service including remote template service and database, return responding error message.
# Conflicts: # api/services/rag_pipeline/pipeline_template/remote/remote_retrieval.py
…he weaviate vector database.
# Conflicts: # api/providers/vdb/vdb-weaviate/src/dify_vdb_weaviate/weaviate_vector.py
# Conflicts: # api/tests/unit_tests/controllers/service_api/dataset/test_hit_testing.py
…e image preview to fail on the chunks details page of the knowledge base.
…e image preview to fail on the chunks details page of the knowledge base.
… is generated for external preview or download only.
…mentSegment type modification.
Contributor
Pyrefly Type Coverage
|
…mentSegment type modification.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36106 +/- ##
=======================================
Coverage 85.87% 85.87%
=======================================
Files 4456 4456
Lines 210959 210985 +26
Branches 39449 39454 +5
=======================================
+ Hits 181162 181191 +29
+ Misses 26573 26572 -1
+ Partials 3224 3222 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hjlarry
previously approved these changes
May 13, 2026
hjlarry
approved these changes
May 13, 2026
FFXN
added a commit
that referenced
this pull request
May 13, 2026
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 13, 2026
BeautyyuYanli
pushed a commit
that referenced
this pull request
May 13, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
FFXN
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #36090
When hit-testing, an empty document dict is returned due to DocumentSegment type modification.
Then the frontend render failed.
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods