Skip to content

fix: knowledge hit-testing render failed. (#36106)#36110

Merged
FFXN merged 1 commit into
hotfix/1.14.1-fix.1from
hotfix/1.14.1-fix.1-issue-36090
May 13, 2026
Merged

fix: knowledge hit-testing render failed. (#36106)#36110
FFXN merged 1 commit into
hotfix/1.14.1-fix.1from
hotfix/1.14.1-fix.1-issue-36090

Conversation

@FFXN
Copy link
Copy Markdown
Contributor

@FFXN FFXN commented May 13, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #36090

When hit-testing, an empty document dict is returned due to DocumentSegment type modification.
Then the frontend render failed.Fixes #36090

When hit-testing, an empty document dict is returned due to DocumentSegment type modification.
Then the frontend render failed.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 43.66% +43.66%
Strict coverage 0.00% 43.19% +43.19%
Typed symbols 0 22,043 +22,043
Untyped symbols 0 28,756 +28,756
Modules 0 2552 +2,552

@FFXN FFXN merged commit fdb4008 into hotfix/1.14.1-fix.1 May 13, 2026
11 checks passed
@FFXN FFXN deleted the hotfix/1.14.1-fix.1-issue-36090 branch May 13, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant