Skip to content

fix(api): require edit access for trace config changes#37973

Merged
wylswz merged 2 commits into
mainfrom
laipz8200/trace-config-permissions
Jun 26, 2026
Merged

fix(api): require edit access for trace config changes#37973
wylswz merged 2 commits into
mainfrom
laipz8200/trace-config-permissions

Conversation

@laipz8200

Copy link
Copy Markdown
Member

Summary

  • Require app edit access and tracing-config RBAC permission before trace config create, update, or delete requests run.
  • Keep trace config reads unchanged.

Screenshots

N/A

Require app edit and tracing-config RBAC permissions before creating, updating, or deleting trace provider config.

Add controller coverage for denied mutation attempts.
@laipz8200 laipz8200 requested a review from QuantumGhost as a code owner June 25, 2026 16:01
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 51.32% 51.33% +0.01%
Strict coverage 50.83% 50.84% +0.01%
Typed symbols 30,543 30,559 +16
Untyped symbols 29,252 29,252 0
Modules 2929 2930 +1

@autofix-ci autofix-ci Bot requested a review from crazywoola as a code owner June 25, 2026 16:05
@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.32%. Comparing base (3aa26fb) to head (64b29a7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37973      +/-   ##
==========================================
- Coverage   85.32%   85.32%   -0.01%     
==========================================
  Files        4932     4932              
  Lines      255717   255737      +20     
  Branches    48454    48456       +2     
==========================================
+ Hits       218183   218197      +14     
- Misses      33290    33294       +4     
- Partials     4244     4246       +2     
Flag Coverage Δ
api 85.57% <100.00%> (-0.01%) ⬇️
dify-ui 94.94% <ø> (ø)
web 84.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laipz8200 laipz8200 added this to the next milestone Jun 26, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2026
@wylswz wylswz added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 0035d90 Jun 26, 2026
42 of 47 checks passed
@wylswz wylswz deleted the laipz8200/trace-config-permissions branch June 26, 2026 01:06
GareArc pushed a commit that referenced this pull request Jun 26, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
GareArc pushed a commit that referenced this pull request Jul 9, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0035d90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants