Skip to content

ci: emit pyrefly diagnostics as GitHub workflow commands#37974

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
ojasarora77:chore/pyrefly-github-output-format-in-ci
Jun 25, 2026
Merged

ci: emit pyrefly diagnostics as GitHub workflow commands#37974
asukaminato0721 merged 1 commit into
langgenius:mainfrom
ojasarora77:chore/pyrefly-github-output-format-in-ci

Conversation

@ojasarora77

@ojasarora77 ojasarora77 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

#36189

Summary

Enables GitHub-formatted pyrefly output in CI style checks so type errors appear as inline PR annotations.

The previous attempt (#36205) added outputformat to pyproject.toml, which used the wrong config key and would also affect local runs. This PR instead:

  • Sets PYREFLY_OUTPUT_FORMAT=github in the style.yml type-check step
  • Teaches dev/pyrefly-check-local to pass --output-format=github and stream output directly in that mode
  • Keeps the existing pyrefly_diagnostics.py formatting for local make type-check runs

From Cursor

Test plan

  • Verified pyrefly check --output-format=github emits ::error workflow commands locally
  • CI style check on this PR should show inline pyrefly annotations if any type errors are reported

Enable GitHub-formatted pyrefly output in CI style checks so type
errors surface as inline PR annotations, while keeping the existing
diagnostics formatter for local runs.
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 25, 2026
@asukaminato0721 asukaminato0721 changed the title chore(ci): emit pyrefly diagnostics as GitHub workflow commands ci: emit pyrefly diagnostics as GitHub workflow commands Jun 25, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue Jun 25, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2026
Merged via the queue into langgenius:main with commit a246dc8 Jun 25, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants