refactor: simplify deployment access ownership#37994
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #37994 +/- ##
==========================================
+ Coverage 85.28% 85.30% +0.01%
==========================================
Files 4938 4931 -7
Lines 256070 256028 -42
Branches 48559 48543 -16
==========================================
+ Hits 218389 218393 +4
+ Misses 33434 33388 -46
Partials 4247 4247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/features/deployments/detailso tab entries live in their owning tab folders and detail-level shared UI lives underdetail/components.web/features/deployments/detail/access-tab, then group its files by access channels, developer API, permissions, and shared access-tab components.No linked issue provided.
Screenshots
Validation
pnpm -C web exec eslint --fix "app/(commonLayout)/deployments/[appInstanceId]/access/page.tsx" "app/(commonLayout)/deployments/[appInstanceId]/api-tokens/page.tsx" features/deployments/detail/index.tsx features/deployments/detail/access-tabpnpm -C web test features/deployments/detail --runpnpm -C web type-checkgit diff --check HEAD~1 HEADChecklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Codex