refactor: Use pytest caplog instead of logger patching in test_spec.py#37997
Merged
Conversation
asukaminato0721
previously approved these changes
Jun 26, 2026
Contributor
Pyrefly Type Coverage
|
asukaminato0721
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #37468 by refactoring the test
test_get_exception_returns_empty_listinapi/tests/unit_tests/controllers/console/test_spec.pyto usepytest'scaplogfixture instead of manually patching the logger.This is part of a larger effort to modernize the test suite and improve log verification.
Changes:
patch.object(spec_module.logger, "exception").caplogfixture to the test method.caplog.text.