fix: isolate node selector keyboard events#37998
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37998 +/- ##
=======================================
Coverage 85.28% 85.28%
=======================================
Files 4938 4938
Lines 256081 256086 +5
Branches 48563 48566 +3
=======================================
+ Hits 218398 218403 +5
Misses 33436 33436
Partials 4247 4247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When Add Nodes is opened from the workflow panel context menu, the Base UI context menu remains open behind the node selector. Its menu keyboard text navigation can consume printable English key events before the selector search can use them. The normal AddBlock entry is unaffected because there is no parent keyboard-managed menu overlay.
Validation
pnpm -C web test app/components/workflow/block-selector/__tests__/main.spec.tsx app/components/workflow/operator/__tests__/add-block.spec.tsx app/components/workflow/__tests__/panel-contextmenu.spec.tsxgit diff --check