Skip to content

chore: migrate account role test to testcontainers#38010

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/migrate-backend-test-style
Jun 26, 2026
Merged

chore: migrate account role test to testcontainers#38010
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/migrate-backend-test-style

Conversation

@escape0707

@escape0707 escape0707 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of #32454

  • Migrates TenantAccountRole.is_privileged_role coverage from the old unit test into the existing Testcontainers account model test.
  • Deletes api/tests/unit_tests/models/test_account.py.
  • Removes models/test_account.py from the Testcontainers Ruff and Pyrefly exclusion lists after cleaning the touched target file.

Targeted verification:

  • uv run ruff check tests/test_containers_integration_tests/models/test_account.py
  • uv run pyrefly check tests/test_containers_integration_tests/models/test_account.py --summary=none --output-format=min-text
  • DOCKER_HOST=unix:///run/user/1000/podman/podman.sock uv run pytest tests/test_containers_integration_tests/models/test_account.py

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 51.34% 51.34% +0.00%
Strict coverage 50.85% 50.86% +0.00%
Typed symbols 30,576 30,576 0
Untyped symbols 29,255 29,254 -1
Modules 2930 2929 -1

@asukaminato0721 asukaminato0721 added this pull request to the merge queue Jun 26, 2026
Merged via the queue into langgenius:main with commit eb4ec93 Jun 26, 2026
33 checks passed
@escape0707 escape0707 deleted the codex/migrate-backend-test-style branch June 26, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants