refactor: replace patch logger with caplog in test_version.py#38029
Merged
asukaminato0721 merged 1 commit intoJun 26, 2026
Merged
Conversation
Replace unittest.mock.patch.object(logger, 'warning') with pytest's caplog fixture for capturing log output in test_http_error_fallback. Fixes langgenius#37468
dosubot
Bot
added
size:XS
Contributor
Pyrefly Type Coverage
|
asukaminato0721
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
unittest.mock.patch.object(logger, 'warning')with pytest'scaplogfixture for capturing log output intest_http_error_fallback.Changes
api/tests/unit_tests/controllers/console/test_version.pytest_http_error_fallbackcaplog: pytest.LogCaptureFixtureparameterpatch.object(version_module.logger, "warning", ) as log_warningcaplog.at_level(logging.WARNING, logger="controllers.console.version")log_warning.assert_called_once()toassert "Check update version error" in caplog.textRelated Issues
#37468
Testing
test_version.pypass