Skip to content

fix: improve members role chip accessibility#38037

Merged
lyzno1 merged 2 commits into
mainfrom
codex/fix-rbac-member-a11y
Jun 26, 2026
Merged

fix: improve members role chip accessibility#38037
lyzno1 merged 2 commits into
mainfrom
codex/fix-rbac-member-a11y

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the member details role chip preview card/dropdown stack with an accessible popover-backed chip
  • move role removal to a dedicated chip close button while keeping the popover focused on permission details
  • make member rows use a native button for the details action without nesting the member actions menu
  • remove production test ids from permission role chips and update tests to use semantic role queries

Testing

  • pnpm -C web test app/components/header/account-setting/members-page/tests/index.spec.tsx app/components/header/account-setting/members-page/member-details-modal/tests/index.spec.tsx app/components/header/account-setting/members-page/tests/role-badges.spec.tsx
  • pnpm --dir web exec eslint app/components/header/account-setting/members-page/member-row.tsx app/components/header/account-setting/members-page/member-menu.tsx app/components/header/account-setting/members-page/role-badges.tsx app/components/header/account-setting/members-page/member-details-modal/permission-role-chip.tsx app/components/header/account-setting/members-page/tests/index.spec.tsx app/components/header/account-setting/members-page/member-details-modal/tests/index.spec.tsx app/components/header/account-setting/members-page/tests/role-badges.spec.tsx
  • pnpm -C web test app/components/header/account-setting/members-page/member-details-modal/tests/index.spec.tsx
  • pnpm --dir web exec eslint app/components/header/account-setting/members-page/member-details-modal/permission-role-chip.tsx app/components/header/account-setting/members-page/member-details-modal/tests/index.spec.tsx
  • git diff --check

@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.27%. Comparing base (00b4cdc) to head (ed92a82).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38037      +/-   ##
==========================================
- Coverage   85.28%   85.27%   -0.01%     
==========================================
  Files        4958     4958              
  Lines      258407   258391      -16     
  Branches    49099    49094       -5     
==========================================
- Hits       220372   220355      -17     
- Misses      33747    33748       +1     
  Partials     4288     4288              
Flag Coverage Δ
dify-ui 94.94% <ø> (ø)
web 84.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 marked this pull request as ready for review June 26, 2026 15:27
@lyzno1 lyzno1 enabled auto-merge June 26, 2026 15:27
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 26, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Jun 26, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2026
Merged via the queue into main with commit 17bee5f Jun 26, 2026
39 checks passed
@lyzno1 lyzno1 deleted the codex/fix-rbac-member-a11y branch June 26, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants