Skip to content

refactor(web): organize deployment feature state#38065

Merged
hyoban merged 29 commits into
mainfrom
codex/deployments-list-state-management
Jun 27, 2026
Merged

refactor(web): organize deployment feature state#38065
hyoban merged 29 commits into
mainfrom
codex/deployments-list-state-management

Conversation

@hyoban

@hyoban hyoban commented Jun 27, 2026

Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Refactor the deployments frontend feature around clearer module boundaries and feature-local state ownership.

  • Align deployment detail tab folders and action surfaces with the product/module boundaries.
  • Move shared deployment UI/domain helpers into web/features/deployments/shared and remove re-export-oriented module shapes.
  • Clean up list, action, create-guide, release, detail, and route-derived state management with explicit state files, scoped primitives, generated query options, and module README dependency notes.

Fixes: N/A

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Validation

Not run in this PR creation step.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 27, 2026
@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.20192% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.37%. Comparing base (00b4cdc) to head (2ec73fc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...b/features/deployments/create-guide/state/utils.ts 35.59% 38 Missing ⚠️
...features/deployments/create-guide/state/queries.ts 64.70% 24 Missing ⚠️
.../features/deployments/create-guide/state/source.ts 68.62% 16 Missing ⚠️
...eatures/deployments/create-guide/state/workflow.ts 83.82% 11 Missing ⚠️
...l/releases/release-actions/deploy-release-menu.tsx 63.63% 4 Missing ⚠️
...es/deployments/shared/hooks/use-infinite-scroll.ts 94.73% 2 Missing ⚠️
...tures/deployments/create-guide/state/primitives.ts 95.45% 1 Missing ⚠️
...b/features/deployments/deployment-actions/state.ts 91.66% 1 Missing ⚠️
...ployments/detail/releases/release-actions/state.ts 96.55% 1 Missing ⚠️
web/features/deployments/detail/state.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38065      +/-   ##
==========================================
+ Coverage   85.28%   85.37%   +0.09%     
==========================================
  Files        4958     4964       +6     
  Lines      258407   258132     -275     
  Branches    49099    49001      -98     
==========================================
+ Hits       220372   220377       +5     
+ Misses      33747    33467     -280     
  Partials     4288     4288              
Flag Coverage Δ
dify-ui 94.93% <ø> (-0.01%) ⬇️
web 85.03% <76.20%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyoban hyoban marked this pull request as ready for review June 27, 2026 06:51
@hyoban hyoban requested review from iamjoel and lyzno1 as code owners June 27, 2026 06:51
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. refactor labels Jun 27, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2026
@hyoban hyoban added this pull request to the merge queue Jun 27, 2026
Merged via the queue into main with commit a14310f Jun 27, 2026
37 of 38 checks passed
@hyoban hyoban deleted the codex/deployments-list-state-management branch June 27, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants