fix(web): align web app nav item width#38146
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38146 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 4964 4964
Lines 258334 258334
Branches 49023 49023
=======================================
Hits 220452 220452
Misses 33593 33593
Partials 4289 4289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
px-2so installed app rows align with the main nav item track.Regression Source
9d3ac1b7b32c074889b36f0d96dd1ed6dde6fe5b(fix: simplify scroll area composition (#38113)), which changedScrollAreaContentinweb-apps-section.tsxfrompx-2topr-5 pl-2.240 - 8 - 8 = 224pxto240 - 8 - 20 = 212px, making Web App items narrower than the Figma nav shell design.Tests
pnpm -C web exec eslint app/components/main-nav/components/web-apps-section.tsxgit diff --check