Skip to content

fix(web): align web app nav item width#38146

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-webapps-nav-item-width
Jun 29, 2026
Merged

fix(web): align web app nav item width#38146
lyzno1 merged 1 commit into
mainfrom
codex/fix-webapps-nav-item-width

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Restores the Web Apps section content padding to px-2 so installed app rows align with the main nav item track.
  • Keeps the fix scoped to the Web Apps list and leaves the default ScrollArea scrollbar styling unchanged.

Regression Source

  • Introduced by 9d3ac1b7b32c074889b36f0d96dd1ed6dde6fe5b (fix: simplify scroll area composition (#38113)), which changed ScrollAreaContent in web-apps-section.tsx from px-2 to pr-5 pl-2.
  • In the 240px main sidebar, that reduced the row track from 240 - 8 - 8 = 224px to 240 - 8 - 20 = 212px, making Web App items narrower than the Figma nav shell design.

Tests

  • pnpm -C web exec eslint app/components/main-nav/components/web-apps-section.tsx
  • git diff --check

@lyzno1 lyzno1 requested a review from iamjoel as a code owner June 29, 2026 05:48
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 29, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 29, 2026
@lyzno1 lyzno1 enabled auto-merge June 29, 2026 05:50
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (d2216fe) to head (3fda8fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38146   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files        4964     4964           
  Lines      258334   258334           
  Branches    49023    49023           
=======================================
  Hits       220452   220452           
  Misses      33593    33593           
  Partials     4289     4289           
Flag Coverage Δ
dify-ui 94.93% <ø> (ø)
web 85.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jun 29, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 29, 2026
Merged via the queue into main with commit fc16fcb Jun 29, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-webapps-nav-item-width branch June 29, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants