feat: support dataset permission migrate to rbac#38166
Merged
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
87f2baf to
8c2030d
Compare
8c2030d to
48d302a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
48d302a to
ba38a99
Compare
Contributor
|
Need to resolve conflict first. |
ba38a99 to
9a8a0c4
Compare
Contributor
Author
done |
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-06-30 05:27:20.478264568 +0000
+++ /tmp/pyrefly_pr.txt 2026-06-30 05:27:10.481196008 +0000
@@ -1938,28 +1938,34 @@
--> tests/unit_tests/commands/test_legacy_model_type_migration.py:36:38
ERROR Object of class `FromClause` has no attribute `insert` [missing-attribute]
--> tests/unit_tests/commands/test_legacy_model_type_migration.py:204:13
+ERROR Argument `list[SimpleNamespace] | list[Unknown]` is not assignable to parameter `rows` with type `list[object]` in function `FakeExecuteResult.__init__` [bad-argument-type]
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:405:38
+ERROR Object of class `object` has no attribute `scope` [missing-attribute]
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:429:12
+ERROR Argument `list[SimpleNamespace] | list[Unknown]` is not assignable to parameter `rows` with type `list[object]` in function `FakeExecuteResult.__init__` [bad-argument-type]
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:461:38
ERROR Object of class `object` has no attribute `callback` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:383:5
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:551:5
ERROR Object of class `object` has no attribute `callback` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:444:5
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:612:5
ERROR Object of class `TextIOBase` has no attribute `name` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:457:17
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:625:17
ERROR Class `object` has no class attribute `__table__` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:541:48
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:709:48
ERROR Class `object` has no class attribute `__table__` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:620:48
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:788:48
ERROR Class `object` has no class attribute `__table__` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:723:48
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:891:48
ERROR Class `object` has no class attribute `__table__` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:801:48
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:969:48
ERROR Class `object` has no class attribute `__table__` [missing-attribute]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:856:42
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1024:42
ERROR Class member `SlowLineOutput.write` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:924:13
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1092:13
ERROR Argument `object` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1226:44
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1394:44
ERROR Argument `SimpleNamespace` is not assignable to parameter `orig` with type `BaseException` in function `sqlalchemy.exc.DBAPIError.__init__` [bad-argument-type]
- --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1250:57
+ --> tests/unit_tests/commands/test_legacy_model_type_migration.py:1418:57
ERROR Expected a callable, got `None` [not-callable]
--> tests/unit_tests/commands/test_reset_encrypt_key_pair.py:18:9
ERROR Object of class `ModuleType` has no attribute `upgrade` [missing-attribute]
|
QuantumGhost
approved these changes
Jun 30, 2026
GareArc
pushed a commit
that referenced
this pull request
Jun 30, 2026
3 tasks
GareArc
pushed a commit
that referenced
this pull request
Jul 9, 2026
(cherry picked from commit 528bf95)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
support migrate dataset permission to rbac service
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods