Skip to content

fix(web): hide deployment access sidebar tab#38229

Merged
hyoban merged 2 commits into
mainfrom
codex/hide-deployment-access-sidebar-tab
Jun 30, 2026
Merged

fix(web): hide deployment access sidebar tab#38229
hyoban merged 2 commits into
mainfrom
codex/hide-deployment-access-sidebar-tab

Conversation

@hyoban

@hyoban hyoban commented Jun 30, 2026

Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Hide the Deployments detail Access tab from the sidebar by adding an explicit hidden flag to the tab definition and filtering hidden tabs during sidebar rendering.

This completes the access-tab hiding behavior in the sidebar after the route tab keys were updated separately. No associated issue was provided.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Validation performed:

  • pnpm -C web exec eslint --fix features/deployments/detail/deployment-sidebar.tsx
  • pnpm -C web type-check
  • Attempted pnpm -C web exec vp staged, but it failed because vite.config.ts does not define a staged config in this checkout.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 30, 2026
@hyoban hyoban marked this pull request as ready for review June 30, 2026 11:44
@hyoban hyoban requested a review from lyzno1 as a code owner June 30, 2026 11:44
@hyoban hyoban enabled auto-merge June 30, 2026 11:44
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 30, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (9393df9) to head (c4cb392).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38229      +/-   ##
==========================================
- Coverage   85.36%   85.36%   -0.01%     
==========================================
  Files        4972     4972              
  Lines      258850   258850              
  Branches    49082    49082              
==========================================
- Hits       220962   220961       -1     
- Misses      33581    33582       +1     
  Partials     4307     4307              
Flag Coverage Δ
dify-ui 94.93% <ø> (ø)
web 85.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyoban hyoban added this pull request to the merge queue Jun 30, 2026
Merged via the queue into main with commit baf2191 Jun 30, 2026
38 checks passed
@hyoban hyoban deleted the codex/hide-deployment-access-sidebar-tab branch June 30, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants