fix(web): hide deployment access sidebar tab#38229
Merged
Merged
Conversation
lyzno1
approved these changes
Jun 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38229 +/- ##
==========================================
- Coverage 85.36% 85.36% -0.01%
==========================================
Files 4972 4972
Lines 258850 258850
Branches 49082 49082
==========================================
- Hits 220962 220961 -1
- Misses 33581 33582 +1
Partials 4307 4307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Hide the Deployments detail Access tab from the sidebar by adding an explicit hidden flag to the tab definition and filtering hidden tabs during sidebar rendering.
This completes the access-tab hiding behavior in the sidebar after the route tab keys were updated separately. No associated issue was provided.
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation performed:
pnpm -C web exec eslint --fix features/deployments/detail/deployment-sidebar.tsxpnpm -C web type-checkpnpm -C web exec vp staged, but it failed becausevite.config.tsdoes not define astagedconfig in this checkout.From Codex