refactor(web): decouple detail sidebars from main nav#38241
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38241 +/- ##
=========================================
Coverage 85.36% 85.36%
=========================================
Files 4979 4973 -6
Lines 262037 259605 -2432
Branches 49629 49388 -241
=========================================
- Hits 223682 221613 -2069
+ Misses 33971 33693 -278
+ Partials 4384 4299 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
This refactors the console navigation ownership so
MainNavonly owns the global navigation bundle. Feature-owned detail sidebars now render from their respective detail layouts and share a neutralDetailSidebarFrameunderapp/components/detail-sidebar.Changes include:
main-nav.MainNavLayouton detail routes that render their own sidebar.main-navinto the snippets feature.main-navagain.No linked issue was provided for this local Codex task.
Validation:
pnpm -C web test app/components/main-nav/__tests__/index.spec.tsx app/components/main-nav/__tests__/layout.spec.tsx app/components/detail-sidebar/__tests__/index.spec.tsxpnpm -C web test 'app/(commonLayout)/app/(appDetailLayout)/[appId]/__tests__/layout-main.spec.tsx' 'app/(commonLayout)/datasets/(datasetDetailLayout)/[datasetId]/__tests__/layout-main.spec.tsx' app/components/snippets/components/__tests__/snippet-layout.spec.tsxpnpm -C web test app/components/app/configuration/hooks/__tests__/use-configuration.spec.tsxpnpm -C web type-checkpnpm -C web lint:tssgit diff --checkNote:
cd web && pnpm exec vp stagedwas attempted, but this checkout reports nostagedconfig invite.config.ts. The commit hook did runeslint --fix --pass-on-unpruned-suppressionssuccessfully.From Codex
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods