refactor: manage rag pipeline sessions explicitly by 41tair · Pull Request #38274 · langgenius/dify

41tair · 2026-07-01T11:48:45Z

Important

Make sure you have read our contribution guidelines
Ensure there is an associated issue and you have been assigned to it
Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

manage rag pipeline sessions explicitly

Screenshots

Before	After
...	...

Checklist

This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

github-actions · 2026-07-01T11:51:17Z

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-07-03 05:11:42.124256314 +0000
+++ /tmp/pyrefly_pr.txt	2026-07-03 05:11:33.772212722 +0000
@@ -6886,135 +6886,139 @@
   --> tests/unit_tests/services/plugin/test_oauth_service.py:68:34
 ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
   --> tests/unit_tests/services/plugin/test_oauth_service.py:95:9
-ERROR Class member `DummyRetrieval.get_pipeline_templates` overrides parent class `PipelineTemplateRetrievalBase` in an inconsistent manner [bad-override]
- --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:5:9
 ERROR Class member `DummyRetrieval.get_pipeline_templates` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:5:9
+ --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:7:9
 ERROR Class member `DummyRetrieval.get_pipeline_template_detail` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
- --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:8:9
-ERROR Class member `DummyRetrieval.get_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
   --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:11:9
+ERROR Class member `DummyRetrieval.get_type` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
+  --> tests/unit_tests/services/rag_pipeline/pipeline_template/test_pipeline_template_base.py:15:9
+ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
+  --> tests/unit_tests/services/rag_pipeline/test_pipeline_generate_service.py:21:5
 ERROR Argument `SimpleNamespace` is not assignable to parameter `session` with type `Session` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_all_published_workflow` [bad-argument-type]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:183:17
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:216:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `session` with type `Session` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_all_published_workflow` [bad-argument-type]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:201:17
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:236:17
 ERROR Argument `list[str]` is not assignable to parameter `environment_variables` with type `Sequence[VariableBase]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.sync_draft_workflow` [bad-argument-type]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:293:31
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:324:31
 ERROR Argument `list[str]` is not assignable to parameter `conversation_variables` with type `Sequence[VariableBase]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.sync_draft_workflow` [bad-argument-type]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:294:32
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:325:32
 ERROR Object of class `NoneType` has no attribute `marked_name` [missing-attribute]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:350:12
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:383:12
 ERROR Object of class `NoneType` has no attribute `marked_comment` [missing-attribute]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:351:12
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:384:12
 ERROR Object of class `NoneType` has no attribute `disallowed`
 ERROR Object of class `NoneType` has no attribute `updated_by` [missing-attribute]
-   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:353:12
+   --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:386:12
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1114:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1144:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1117:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1147:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1161:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1191:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1164:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1194:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1209:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1239:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1212:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1242:21
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1258:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1288:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_first_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1276:56
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1306:64
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_second_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1304:62
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1334:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1401:55
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1429:63
 ERROR Argument `SimpleNamespace` is not assignable to parameter `current_user` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1401:88
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1429:96
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1439:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1467:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1442:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1470:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1492:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1520:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1495:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1523:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1547:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1575:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1550:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1578:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_first_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1565:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1593:69
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_second_step_parameters` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1596:62
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1624:70
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1608:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1636:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1608:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1636:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1608:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1636:61
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[object, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1640:20
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1667:20
 ERROR Argument `() -> tuple[SimpleNamespace, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1700:16
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1724:16
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1755:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1776:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1758:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1779:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `session` with type `Session` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.get_all_published_workflow` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1852:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1881:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.publish_workflow` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1883:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1912:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.publish_workflow` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1884:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1913:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1945:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1974:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1948:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1977:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1993:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2022:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_workflow_node` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1996:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2025:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2042:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2071:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2045:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2074:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2121:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2146:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2121:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2146:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2121:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2146:61
 ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2136:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2160:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `document` with type `Document` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2136:32
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2160:32
 ERROR Argument `SimpleNamespace` is not assignable to parameter `user` with type `Account | EndUser` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.retry_error_document` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2136:61
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2160:61
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.publish_workflow` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2176:73
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2200:39
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.publish_workflow` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2176:91
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2200:57
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2186:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2211:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2189:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2214:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2204:22
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2229:22
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2207:21
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2232:21
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2251:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2276:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2254:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2279:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2292:18
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2317:18
 ERROR Argument `SimpleNamespace` is not assignable to parameter `account` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.run_datasource_node_preview` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2295:17
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2320:17
 ERROR Argument `SimpleNamespace` is not assignable to parameter `pipeline` with type `Pipeline` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2309:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2334:13
 ERROR Argument `SimpleNamespace` is not assignable to parameter `current_user` with type `Account` in function `services.rag_pipeline.rag_pipeline.RagPipelineService.set_datasource_variables` [bad-argument-type]
-    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2311:13
+    --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:2336:13
+ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
+  --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_transform_service.py:21:5
+ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
+  --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_transform_service.py:22:5
 ERROR Argument `dict[str, int]` is not assignable to parameter `manifest` with type `ArchiveManifest` in function `services.retention.workflow_run.restore_archived_workflow_run.WorkflowRunRestore._get_schema_version` [bad-argument-type]
    --> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:342:41
 ERROR Argument `() -> Mock` is not assignable to parameter `session_maker` with type `sessionmaker[Unknown]` in function `services.retention.workflow_run.restore_archived_workflow_run.WorkflowRunRestore._restore_from_run` [bad-argument-type]

github-actions · 2026-07-01T11:52:11Z

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	52.27%	52.29%	+0.03%
Strict coverage	51.78%	51.81%	+0.03%
Typed symbols	31,977	32,014	+37
Untyped symbols	29,478	29,477	-1
Modules	2969	2970	+1

…ne-db-session

refactor: manage rag pipeline sessions explicitly

83ee225

41tair requested review from JohnJyong, QuantumGhost and laipz8200 as code owners July 1, 2026 11:48

dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. refactor labels Jul 1, 2026

41tair mentioned this pull request Jul 1, 2026

make db.session pass from parameter. #37403

Open

fix integration test

4aeb71f

asukaminato0721 enabled auto-merge July 2, 2026 09:44

41tair disabled auto-merge July 2, 2026 10:30

add more session paramters under ragpipeline

4935d53

QuantumGhost reviewed Jul 2, 2026

View reviewed changes

Comment thread api/controllers/service_api/dataset/rag_pipeline/rag_pipeline_workflow.py

QuantumGhost reviewed Jul 2, 2026

View reviewed changes

Comment thread api/services/rag_pipeline/pipeline_template/built_in/built_in_retrieval.py

QuantumGhost reviewed Jul 2, 2026

View reviewed changes

Comment thread api/services/rag_pipeline/rag_pipeline_transform_service.py Outdated

QuantumGhost reviewed Jul 2, 2026

View reviewed changes

Comment thread api/services/rag_pipeline/rag_pipeline_transform_service.py Outdated

41tair added 2 commits July 3, 2026 10:13

Merge branch 'main' of github.com:langgenius/dify into svc-rag-pipeli…

12e27ac

…ne-db-session

use session flush in services to avoid the session different life cycle

f17e695

41tair force-pushed the refator/svc-rag-pipeline-db-session branch from d8ed8e4 to f17e695 Compare July 3, 2026 03:10

fix integration test

96f145b

QuantumGhost approved these changes Jul 3, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2026

QuantumGhost added this pull request to the merge queue Jul 3, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 3, 2026

41tair added this pull request to the merge queue Jul 3, 2026

Merged via the queue into langgenius:main with commit 5cb76f5 Jul 3, 2026
31 checks passed

41tair deleted the refator/svc-rag-pipeline-db-session branch July 3, 2026 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: manage rag pipeline sessions explicitly#38274

refactor: manage rag pipeline sessions explicitly#38274
41tair merged 6 commits into
langgenius:mainfrom
41tair:refator/svc-rag-pipeline-db-session

41tair commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

41tair commented Jul 1, 2026

Summary

Screenshots

Checklist

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pyrefly Diff

Uh oh!

github-actions Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pyrefly Type Coverage

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 1, 2026 •

edited

Loading

github-actions Bot commented Jul 1, 2026 •

edited

Loading