refactor(ui): use inset ring utilities#38275
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38275 +/- ##
==========================================
- Coverage 85.35% 85.35% -0.01%
==========================================
Files 4981 4981
Lines 262024 262024
Branches 49606 49606
==========================================
- Hits 223662 223660 -2
- Misses 33978 33980 +2
Partials 4384 4384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ring-* + ring color + ring-insetclass groups with Tailwind v4inset-ring-*utilitiesring-insetcall sites unchanged when width/color come from an upstream component or dynamic class compositionRationale
Tailwind v4 exposes inset ring utilities directly, so static inset ring groups can use the narrower utility pair without changing the rendered focus or selection treatment. Tests should not lock this kind of utility spelling; behavior and accessibility tests remain in place.
Validation
pnpm exec eslint --fix $(git diff --name-only | tr '\n' ' ')pnpm --filter @langgenius/dify-ui test -- src/select/__tests__/index.spec.tsx src/segmented-control/__tests__/index.spec.tsxpnpm -C web test app/components/app-sidebar/app-info/__tests__/app-operations.spec.tsx app/components/base/chip/__tests__/index.spec.tsx app/components/base/file-uploader/file-uploader-in-chat-input/__tests__/index.spec.tsx app/components/base/search-input/__tests__/index.spec.tsx app/components/datasets/list/dataset-card/components/__tests__/operations-dropdown.spec.tsx app/components/develop/__tests__/md.spec.tsx app/components/develop/__tests__/tag.spec.tsx app/components/explore/app-card/__tests__/index.spec.tsx app/components/explore/sidebar/app-nav-item/__tests__/index.spec.tsx app/components/integrations/__tests__/tool-provider-list.spec.tsx features/agent-v2/roster/components/__tests__/agent-roster-list.spec.tsxpnpm -C web type-checkpnpm --filter @langgenius/dify-ui type-checkweb/app/styles/globals.cssgit diff --check