Skip to content

fix(web): fill dataset create layout height#38308

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-dataset-create-height
Jul 2, 2026
Merged

fix(web): fill dataset create layout height#38308
lyzno1 merged 1 commit into
mainfrom
codex/fix-dataset-create-height

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • let the dataset create page inherit the main layout height instead of subtracting the nav height again
  • replace the inner percentage height calculation with flex growth so the panel background reaches the bottom

Verification

  • pnpm -C web exec eslint app/components/datasets/create/index.tsx (passes with existing react/use-state warnings)
  • git diff --check

@lyzno1 lyzno1 requested review from WTW0313 and iamjoel as code owners July 2, 2026 08:03
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 2, 2026
@lyzno1 lyzno1 enabled auto-merge July 2, 2026 08:04
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.29%. Comparing base (451faa0) to head (d8a1703).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38308   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files        4982     4982           
  Lines      263228   263228           
  Branches    50023    50023           
=======================================
  Hits       224509   224509           
  Misses      34335    34335           
  Partials     4384     4384           
Flag Coverage Δ
dify-ui 94.93% <ø> (ø)
web 84.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit 6ec56e7 Jul 2, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-dataset-create-height branch July 2, 2026 08:17
lyzno1 added a commit that referenced this pull request Jul 2, 2026
hjlarry pushed a commit that referenced this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-linear lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants