fix: normalize query array params for oRPC#38322
Merged
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-07-02 10:32:18.042736263 +0000
+++ /tmp/pyrefly_pr.txt 2026-07-02 10:32:09.399819511 +0000
@@ -1,3 +1,5 @@
+ERROR `dict[str, str]` is not assignable to `dict[str, list[str] | str]` [bad-assignment]
+ --> controllers/console/workspace/snippets.py:145:46
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
--> providers/vdb/vdb-alibabacloud-mysql/tests/unit_tests/test_alibabacloud_mysql_factory.py:42:38
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #38322 +/- ##
=======================================
Coverage 85.29% 85.29%
=======================================
Files 4980 4981 +1
Lines 263365 263321 -44
Branches 50039 50026 -13
=======================================
- Hits 224625 224588 -37
+ Misses 34348 34345 -3
+ Partials 4392 4388 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #38318
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation performed:
uv run --project api pytest api/tests/unit_tests/controllers/console/app/test_app_response_models.py api/tests/unit_tests/controllers/console/snippets/test_snippet_list_query.py api/tests/unit_tests/controllers/console/workspace/test_snippets.py api/tests/unit_tests/controllers/console/agent/test_agent_controllers.py api/tests/unit_tests/controllers/console/workspace/test_tool_providers.pyuv run --project api ruff check api/controllers/console/app/app.py api/controllers/console/agent/roster.py api/controllers/console/snippets/payloads.py api/controllers/console/workspace/snippets.py api/controllers/console/workspace/tool_providers.py api/tests/unit_tests/controllers/console/app/test_app_response_models.py api/tests/unit_tests/controllers/console/snippets/test_snippet_list_query.py api/tests/unit_tests/controllers/console/workspace/test_snippets.py api/tests/unit_tests/controllers/console/agent/test_agent_controllers.py api/tests/unit_tests/controllers/console/workspace/test_tool_providers.pypnpm test service/client.spec.tspnpm exec eslint service/client.ts service/client.spec.ts service/console-openapi-url.tspnpm type-checkFrom Codex