Skip to content

fix: prevent app card meta overflow#38349

Merged
hjlarry merged 2 commits into
mainfrom
fix/app-card-style-alignment
Jul 3, 2026
Merged

fix: prevent app card meta overflow#38349
hjlarry merged 2 commits into
mainfrom
fix/app-card-style-alignment

Conversation

@Jingyi-Dify

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes Linear SNP-509.

This PR prevents the app card footer metadata from overlapping the bottom-right access-mode icon when the author/time text is too long. The footer row now clips overflowing content, and the edited time text can shrink and truncate instead of forcing the row into the decorative icon area.

From Codex

Screenshots

Before After
Footer metadata could run underneath the bottom-right access icon when space was tight. Footer metadata stays within the available row width and truncates before the icon area.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Validation:

  • CI=true pnpm -C web test app/components/apps/__tests__/app-card.spec.tsx
  • CI=true pnpm -C web exec eslint app/components/apps/app-card.tsx app/components/apps/__tests__/app-card.spec.tsx failed on pre-existing a11y lint issues outside this diff.
  • CI=true pnpm -C web exec vp staged failed because the current vite.config.ts has no staged config.

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 2, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.29%. Comparing base (57f687f) to head (7225538).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38349   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files        4981     4981           
  Lines      263425   263425           
  Branches    50019    50019           
=======================================
  Hits       224694   224694           
  Misses      34343    34343           
  Partials     4388     4388           
Flag Coverage Δ
dify-ui 94.93% <ø> (ø)
web 84.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hjlarry hjlarry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2026
@hjlarry hjlarry added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit d120995 Jul 3, 2026
38 checks passed
@hjlarry hjlarry deleted the fix/app-card-style-alignment branch July 3, 2026 01:57
hjlarry pushed a commit that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants