Skip to content

fix(dify-ui): standardize story focus indicators#38417

Merged
lyzno1 merged 12 commits into
mainfrom
codex/dify-ui-story-focus-visible
Jul 4, 2026
Merged

fix(dify-ui): standardize story focus indicators#38417
lyzno1 merged 12 commits into
mainfrom
codex/dify-ui-story-focus-visible

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Standardize story-local raw triggers, buttons, and links on Dify token focus rings instead of browser/default outline styles.
  • Align raw dialog/popover inputs with Dify input focus treatment.
  • Remove the unused ScrollArea AppSidebar story instead of carrying a local focus-style fix for it.

Validation

  • pnpm -C packages/dify-ui exec eslint src/alert-dialog/index.stories.tsx src/dialog/index.stories.tsx src/popover/index.stories.tsx src/dropdown-menu/index.stories.tsx src/context-menu/index.stories.tsx src/tooltip/index.stories.tsx src/preview-card/index.stories.tsx src/toast/index.stories.tsx src/kbd/index.stories.tsx src/switch/index.stories.tsx src/radio-group/index.stories.tsx src/collapsible/index.stories.tsx src/scroll-area/index.stories.tsx
  • pnpm -C packages/dify-ui type-check
  • git diff --check

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. refactor labels Jul 4, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 4, 2026
@lyzno1 lyzno1 enabled auto-merge July 4, 2026 13:43
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.30%. Comparing base (a0f8347) to head (cc839ac).

Files with missing lines Patch % Lines
packages/dify-ui/src/dialog/index.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38417   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files        4995     4995           
  Lines      264319   264326    +7     
  Branches    50141    50141           
=======================================
+ Hits       225473   225479    +6     
- Misses      34428    34429    +1     
  Partials     4418     4418           
Flag Coverage Δ
dify-ui 94.75% <71.42%> (-0.18%) ⬇️
web 84.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 disabled auto-merge July 4, 2026 14:01
@lyzno1 lyzno1 marked this pull request as draft July 4, 2026 14:01
@lyzno1 lyzno1 marked this pull request as ready for review July 4, 2026 14:30
@lyzno1 lyzno1 enabled auto-merge July 4, 2026 14:30
@lyzno1 lyzno1 added this pull request to the merge queue Jul 4, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2026
Merged via the queue into main with commit 5d7ae56 Jul 4, 2026
37 of 38 checks passed
@lyzno1 lyzno1 deleted the codex/dify-ui-story-focus-visible branch July 4, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants