Skip to content

ci: extract external E2E into dedicated post-merge workflow#38426

Merged
lyzno1 merged 3 commits into
mainfrom
copilot/e2e
Jul 5, 2026
Merged

ci: extract external E2E into dedicated post-merge workflow#38426
lyzno1 merged 3 commits into
mainfrom
copilot/e2e

Conversation

Copilot AI commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

External runtime E2E was never actually executing. skip-duplicate-actions (same_content_newer) on push: main would mark the run as duplicate of the successful PR CI — which never ran external E2E (run-external-runtime is gated to push+main only). The result: external E2E was permanently skipped.

Root cause is structural: PR validation and post-merge validation have different lifecycles and must not share the same workflow + skip logic.

Summary

main-ci.yml

  • Remove push: branches: ["main"] trigger — this workflow now only runs on pull_request and merge_group
  • Remove run-external-runtime parameter from web-e2e-run — PR-stage E2E never runs external; defaults to false

post-merge.yml (new)

  • Triggered exclusively on push: branches: ["main"]
  • Runs dorny/paths-filter with the same external_e2e path set as main-ci.yml
  • Calls web-e2e.yml with run-external-runtime: true only when relevant files changed
  • cancel-in-progress: false — post-merge jobs should not cancel each other

Screenshots

Before After
External E2E never executes (always skipped by duplicate-action cache) External E2E runs on each push to main where external_e2e paths changed

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

From GitHub Copilot

@lyzno1 lyzno1 marked this pull request as ready for review July 5, 2026 10:42
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 5, 2026
@lyzno1 lyzno1 enabled auto-merge July 5, 2026 10:42
@lyzno1 lyzno1 added this pull request to the merge queue Jul 5, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2026
Merged via the queue into main with commit abaf6b1 Jul 5, 2026
32 checks passed
@lyzno1 lyzno1 deleted the copilot/e2e branch July 5, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants