Skip to content

fix(web): prevent plugin cards from overlapping marketplace panel#38427

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-plugin-card-stacking
Jul 5, 2026
Merged

fix(web): prevent plugin cards from overlapping marketplace panel#38427
lyzno1 merged 1 commit into
mainfrom
codex/fix-plugin-card-stacking

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the stale z-index from installed plugin card inner surfaces so they stay in normal scroll content paint order
  • remove the same z-index from the matching plugin list skeleton
  • drop the undefined hover-bg marker from plugin item and install loading surfaces; keep the documented page-feedback marker in marketplace cards untouched

Verification

  • pnpm --dir web exec vitest run app/components/plugins/plugin-item/tests/index.spec.tsx
  • git diff --check

Notes

  • pnpm --dir web exec eslint app/components/plugins/plugin-item/index.tsx still reports existing any, non-interactive click handler, and Remix icon warnings/errors unrelated to this patch.
    Refs SNP-516

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 5, 2026
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.30%. Comparing base (1b3e8e9) to head (af34377).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38427      +/-   ##
==========================================
- Coverage   85.35%   85.30%   -0.06%     
==========================================
  Files        5159     5004     -155     
  Lines      269252   264921    -4331     
  Branches    51418    50360    -1058     
==========================================
- Hits       229810   225978    -3832     
+ Misses      35005    34506     -499     
  Partials     4437     4437              
Flag Coverage Δ
cli ?
dify-ui 94.75% <ø> (ø)
web 84.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 marked this pull request as ready for review July 5, 2026 13:05
@lyzno1 lyzno1 requested review from iamjoel and zhsama as code owners July 5, 2026 13:05
@lyzno1 lyzno1 enabled auto-merge July 5, 2026 13:05
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 5, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Jul 5, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2026
Merged via the queue into main with commit acfef79 Jul 5, 2026
39 checks passed
@lyzno1 lyzno1 deleted the codex/fix-plugin-card-stacking branch July 5, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-linear lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants