Skip to content

fix(web): add backdrop blur to skip nav#38517

Merged
lyzno1 merged 1 commit into
mainfrom
codex/skip-nav-backdrop-blur
Jul 7, 2026
Merged

fix(web): add backdrop blur to skip nav#38517
lyzno1 merged 1 commit into
mainfrom
codex/skip-nav-backdrop-blur

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Add backdrop blur to the skip navigation link so the translucent secondary-button surface remains readable in dark mode.

Tests

  • pnpm -C web test app/components/main-nav/tests/layout.spec.tsx app/components/main-nav/tests/skip-nav.spec.tsx

@lyzno1 lyzno1 requested a review from iamjoel as a code owner July 7, 2026 12:46
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 7, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2026
@lyzno1 lyzno1 enabled auto-merge July 7, 2026 12:47
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.33%. Comparing base (2c6ec1a) to head (065a04e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #38517   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files        5005     5005           
  Lines      265421   265421           
  Branches    50474    50474           
=======================================
  Hits       226504   226504           
  Misses      34469    34469           
  Partials     4448     4448           
Flag Coverage Δ
dify-ui 94.72% <ø> (ø)
web 84.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit 3ddfba5 Jul 7, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/skip-nav-backdrop-blur branch July 7, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants