Skip to content

test(web): align auth e2e with console home#38538

Merged
lyzno1 merged 2 commits into
mainfrom
codex/console-home-auth-e2e
Jul 8, 2026
Merged

test(web): align auth e2e with console home#38538
lyzno1 merged 2 commits into
mainfrom
codex/console-home-auth-e2e

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Align auth/default-entry E2E semantics with the console home route (/) instead of forcing /apps through redirect_url.
  • Keep /apps as the Studio/apps-console surface and add a separate reusable waitForConsoleHome helper for the default console entry.
  • Add an E2E session-refresh scenario that removes the access token, keeps the refresh token, verifies /auth/refresh?redirect_url=/, and lands back on console home.
  • Add focused web unit coverage for NormalForm default post-login fallback to / and basePath-aware /auth/refresh behavior.

Verification

  • pnpm -C web test app/signin/__tests__/normal-form.spec.tsx app/auth/refresh/__tests__/route.spec.ts
  • pnpm -C e2e type-check
  • pnpm -C e2e e2e:middleware:up
  • E2E_START_AGENT_BACKEND=0 pnpm -C e2e e2e -- --tags '@smoke and not @fresh and not @skip'
  • E2E_START_AGENT_BACKEND=0 pnpm -C e2e e2e -- --name 'Refresh the console session during server-side navigation'
  • vpr lint --fix --quiet
  • git diff --check

@lyzno1 lyzno1 requested review from douxc and iamjoel as code owners July 8, 2026 05:52
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2026
@github-actions github-actions Bot added web This relates to changes on the web. e2e End-to-end tests and E2E test infrastructure. labels Jul 8, 2026
@lyzno1 lyzno1 enabled auto-merge July 8, 2026 05:53
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (6ac7ff6) to head (24626d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38538      +/-   ##
==========================================
- Coverage   85.39%   85.34%   -0.06%     
==========================================
  Files        5170     5013     -157     
  Lines      270183   265787    -4396     
  Branches    51604    50528    -1076     
==========================================
- Hits       230719   226832    -3887     
+ Misses      35016    34507     -509     
  Partials     4448     4448              
Flag Coverage Δ
cli ?
dify-ui 94.61% <ø> (ø)
web 84.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Jul 8, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2026
Merged via the queue into main with commit 10cf9be Jul 8, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/console-home-auth-e2e branch July 8, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e End-to-end tests and E2E test infrastructure. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants