refactor(web): migrate account settings app context consumers#38544
Merged
Conversation
6 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38544 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 5013 5013
Lines 265817 265842 +25
Branches 50538 50545 +7
=======================================
+ Hits 226863 226886 +23
- Misses 34506 34508 +2
Partials 4448 4448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Migrate account settings, account dropdown/header, and delete-account AppContext consumers to direct bootstrap atom reads.
This keeps the existing compatibility provider in place while narrowing subscriptions to exact account, workspace, permission, role, version, and refresh atoms at each use site. It also updates related tests to mock the precise app-context-state atoms used by the migrated components.
Refs #38514
From Codex
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation:
pnpm -C web exec eslint --fix --cache --quiet <changed TS/TSX files>pnpm -C web type-checkpnpm -C web test app/components/header/account-dropdown/__tests__/index.spec.tsx app/components/header/env-nav/__tests__/index.spec.tsx app/components/header/account-setting/__tests__/index.spec.tsx app/components/header/account-setting/members-page/__tests__/index.spec.tsx app/components/header/account-setting/members-page/__tests__/invite-button.spec.tsx app/components/header/account-setting/members-page/edit-workspace-modal/__tests__/index.spec.tsx app/components/header/account-setting/members-page/edit-workspace-modal/__tests__/dialog.spec.tsx app/components/header/account-setting/members-page/transfer-ownership-modal/__tests__/index.spec.tsx app/components/header/account-setting/permissions-page/__tests__/index.spec.tsx app/components/header/account-setting/permissions-page/role-list/__tests__/row-menu.spec.tsx app/components/header/account-setting/api-based-extension-page/__tests__/index.spec.tsx app/components/header/account-setting/access-rules-page/__tests__/access-rule-section.spec.tsx app/components/header/account-setting/model-provider-page/system-model-selector/__tests__/index.spec.tsx app/components/header/account-setting/model-provider-page/provider-added-card/__tests__/index.spec.tsx app/components/header/account-setting/model-provider-page/provider-added-card/__tests__/model-list.spec.tsx app/components/header/account-setting/model-provider-page/provider-added-card/__tests__/model-list-item.spec.tsx app/components/header/account-setting/preference-page/__tests__/index.spec.tsxNote:
pnpm -C web exec vp stagedcurrently exits before checks withNo "staged" config found in vite.config.ts, so I ran the equivalent explicit frontend checks above.