Skip to content

fix: display errors for oauth page#38546

Merged
lyzno1 merged 3 commits into
mainfrom
fix/display-error-and-cleanup
Jul 8, 2026
Merged

fix: display errors for oauth page#38546
lyzno1 merged 3 commits into
mainfrom
fix/display-error-and-cleanup

Conversation

@crazywoola

@crazywoola crazywoola commented Jul 8, 2026

Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

close #38543

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@crazywoola crazywoola requested review from douxc and iamjoel as code owners July 8, 2026 07:43
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (5a210cf) to head (785eed8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38546      +/-   ##
==========================================
- Coverage   85.34%   85.34%   -0.01%     
==========================================
  Files        5013     5013              
  Lines      265817   265817              
  Branches    50538    50538              
==========================================
- Hits       226863   226862       -1     
- Misses      34506    34507       +1     
  Partials     4448     4448              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 84.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 8, 2026
lyzno1
lyzno1 previously approved these changes Jul 8, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2026
@lyzno1 lyzno1 enabled auto-merge July 8, 2026 07:56
@lyzno1 lyzno1 added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 5ffd434 Jul 8, 2026
38 checks passed
@lyzno1 lyzno1 deleted the fix/display-error-and-cleanup branch July 8, 2026 08:15
lyzno1 pushed a commit that referenced this pull request Jul 8, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 5ffd434)
lyzno1 pushed a commit that referenced this pull request Jul 8, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 5ffd434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: buttons and texts are missing in oauth page

2 participants