refactor(web): migrate workflow app context consumers#38552
Merged
Conversation
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38552 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 5013 5013
Lines 265940 265942 +2
Branches 50558 50558
=======================================
+ Hits 226978 226980 +2
Misses 34509 34509
Partials 4453 4453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Related to #38514.
Migrates workflow editor AppContext consumers to direct bootstrap atom reads. This keeps workflow-specific calculations at the original call sites while narrowing subscriptions for user profile, workspace, and permission-key dependencies.
Updated focused workflow tests to mock the exact app-context-state atoms used by the migrated components.
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation:
pnpm --dir web test app/components/workflow/comment/comment-input.spec.tsx app/components/workflow/comment/comment-icon.spec.tsx app/components/workflow/comment/thread.spec.tsx app/components/workflow/panel/comments-panel/__tests__/index.spec.tsx app/components/workflow/hooks/__tests__/use-workflow-comment.spec.ts app/components/workflow/__tests__/selection-contextmenu.spec.tsx app/components/workflow/nodes/human-input/components/delivery-method/__tests__/method-item.spec.tsx app/components/workflow/nodes/human-input/components/delivery-method/__tests__/email-configure-modal.spec.tsx app/components/workflow/nodes/human-input/components/delivery-method/__tests__/test-email-sender.spec.tsx app/components/workflow/nodes/human-input/components/delivery-method/recipient/__tests__/index.spec.tsx app/components/workflow/panel/version-history-panel/__tests__/index.spec.tsx app/components/workflow/header/__tests__/header-in-restoring.spec.tsx app/components/workflow/header/__tests__/header-layouts.spec.tsxpnpm --dir web type-checkeslint --fix --pass-on-unpruned-suppressionsNote:
pnpm --dir web exec vp stagedis currently unavailable in this checkout because nostagedconfig is defined inweb/vite.config.ts.From Codex