refactor(web): sync app context effects with jotai#38570
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38570 +/- ##
==========================================
+ Coverage 85.34% 85.39% +0.05%
==========================================
Files 5016 5174 +158
Lines 266941 271378 +4437
Branches 50816 51906 +1090
==========================================
+ Hits 227814 231742 +3928
- Misses 34660 35169 +509
Partials 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEffecthooks with ajotai-effectatom that syncs Zendesk fields and Amplitude identity from app-context atoms.CommonLayoutHydrationBoundary, shared by the authenticated common layouts.jotai-effectas a frontend dependency and updates focused tests around app context bootstrap and common layout hydration.Related issue: N/A
Screenshots
Checklist
pnpm --dir web test app/(commonLayout)/__tests__/hydration-boundary.spec.tsx context/__tests__/app-bootstrap-effects.spec.tsx --runandpnpm --dir web type-check.From Codex