Skip to content

fix: when delete custom model remove its cache#38577

Merged
hjlarry merged 1 commit into
langgenius:mainfrom
hjlarry:p456
Jul 9, 2026
Merged

fix: when delete custom model remove its cache#38577
hjlarry merged 1 commit into
langgenius:mainfrom
hjlarry:p456

Conversation

@hjlarry

@hjlarry hjlarry commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #38576

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 9, 2026
@hjlarry hjlarry enabled auto-merge July 9, 2026 01:40
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 52.59% 52.59% 0.00%
Strict coverage 52.11% 52.11% 0.00%
Typed symbols 32,538 32,538 0
Untyped symbols 29,605 29,605 0
Modules 2982 2982 0

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-07-09 01:43:45.415278042 +0000
+++ /tmp/pyrefly_pr.txt	2026-07-09 01:43:36.989252464 +0000
@@ -4303,21 +4303,21 @@
 ERROR Argument `SimpleNamespace` is not assignable to parameter `db_provider` with type `MCPToolProvider` in function `core.entities.mcp_provider.MCPProviderEntity.from_db_model` [bad-argument-type]
   --> tests/unit_tests/core/entities/test_entities_mcp_provider.py:60:46
 ERROR `None` is not subscriptable [unsupported-operation]
-   --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:807:12
+   --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:808:12
 ERROR Argument `SimpleNamespace` is not assignable to parameter `credential_record` with type `ProviderCredential | ProviderModelCredential` in function `core.entities.provider_configuration.ProviderConfiguration._update_load_balancing_configs_with_credential` [bad-argument-type]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1035:31
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1036:31
 ERROR Argument `SimpleNamespace` is not assignable to parameter `credential_record` with type `ProviderCredential | ProviderModelCredential` in function `core.entities.provider_configuration.ProviderConfiguration._update_load_balancing_configs_with_credential` [bad-argument-type]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1054:27
-ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1170:12
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1055:27
 ERROR `None` is not subscriptable [unsupported-operation]
     --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1171:12
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1187:12
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1172:12
+ERROR `None` is not subscriptable [unsupported-operation]
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1188:12
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1699:12
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1702:12
 ERROR `None` is not subscriptable [unsupported-operation]
-    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1891:12
+    --> tests/unit_tests/core/entities/test_entities_provider_configuration.py:1894:12
 ERROR Object of class `ModuleType` has no attribute `MockExtension` [missing-attribute]
   --> tests/unit_tests/core/extension/test_extensible.py:62:9
 ERROR Cannot index into `OrderedDict[str, ModuleExtension]` [bad-index]

@hjlarry hjlarry added this pull request to the merge queue Jul 9, 2026
Merged via the queue into langgenius:main with commit 5741f8f Jul 9, 2026
56 of 57 checks passed
@hjlarry hjlarry deleted the p456 branch July 9, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when delete custom model not remove its cache

2 participants