Skip to content

fix(web): preserve attribution from auth redirect#38583

Merged
CodingOnStar merged 4 commits into
mainfrom
fix/report-slug
Jul 9, 2026
Merged

fix(web): preserve attribution from auth redirect#38583
CodingOnStar merged 4 commits into
mainfrom
fix/report-slug

Conversation

@CodingOnStar

Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@CodingOnStar CodingOnStar requested a review from lyzno1 July 9, 2026 04:22
@CodingOnStar CodingOnStar requested a review from iamjoel as a code owner July 9, 2026 04:22
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 9, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 9, 2026
lyzno1
lyzno1 previously approved these changes Jul 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.34%. Comparing base (5741f8f) to head (d93965f).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...b/app/components/external-attribution-recorder.tsx 96.15% 1 Missing ⚠️
web/utils/create-app-tracking.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38583      +/-   ##
==========================================
- Coverage   85.34%   85.34%   -0.01%     
==========================================
  Files        5017     5017              
  Lines      266989   267020      +31     
  Branches    50826    50832       +6     
==========================================
+ Hits       227857   227883      +26     
- Misses      34663    34668       +5     
  Partials     4469     4469              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 84.84% <95.65%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 9, 2026
@CodingOnStar CodingOnStar enabled auto-merge July 9, 2026 07:29
@CodingOnStar CodingOnStar added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit 063e390 Jul 9, 2026
38 checks passed
@CodingOnStar CodingOnStar deleted the fix/report-slug branch July 9, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants