Skip to content

fix: guard chat tree against out-of-order parents#38590

Merged
iamjoel merged 1 commit into
mainfrom
fix/child-message-exist-before-parent-message
Jul 9, 2026
Merged

fix: guard chat tree against out-of-order parents#38590
iamjoel merged 1 commit into
mainfrom
fix/child-message-exist-before-parent-message

Conversation

@iamjoel

@iamjoel iamjoel commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@iamjoel iamjoel requested a review from zxhlyh as a code owner July 9, 2026 06:41
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 9, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (6540d17) to head (44ef6f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38590      +/-   ##
==========================================
- Coverage   85.34%   85.34%   -0.01%     
==========================================
  Files        5017     5017              
  Lines      266979   266992      +13     
  Branches    50824    50827       +3     
==========================================
+ Hits       227844   227855      +11     
- Misses      34668    34670       +2     
  Partials     4467     4467              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 84.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamjoel iamjoel enabled auto-merge July 9, 2026 06:56
@iamjoel iamjoel added this pull request to the merge queue Jul 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2026
Merged via the queue into main with commit 3b3c252 Jul 9, 2026
38 checks passed
@iamjoel iamjoel deleted the fix/child-message-exist-before-parent-message branch July 9, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants