fix: sync RBAC whitelist when dataset permission is set to all team - #38952
Merged
Conversation
GareArc
requested review from
JohnJyong,
QuantumGhost and
laipz8200
as code owners
July 14, 2026 10:21
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-07-14 10:48:33.093966064 +0000
+++ /tmp/pyrefly_pr.txt 2026-07-14 10:48:24.582908128 +0000
@@ -6854,6 +6854,8 @@
--> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:760:71
ERROR `in` is not supported between `Literal['not found']` and `None` [not-iterable]
--> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:907:16
+ERROR Argument `SimpleNamespace` is not assignable to parameter `session` with type `Session` in function `services.account_service.TenantService.iter_member_account_id_batches` [bad-argument-type]
+ --> tests/unit_tests/services/test_account_service.py:693:81
ERROR Argument `_FakeWriteSession` is not assignable to parameter `session` with type `scoped_session[Unknown]` in function `services.agent_app_feature_service.AgentAppFeatureConfigService.update_features` [bad-argument-type]
--> tests/unit_tests/services/test_agent_app_feature_service.py:102:21
ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
@@ -7612,6 +7614,8 @@
--> tests/unit_tests/tasks/test_human_input_timeout_tasks.py:117:43
ERROR Argument `SimpleNamespace` is not assignable to parameter `form_model` with type `HumanInputForm` in function `tasks.human_input_timeout_tasks._is_global_timeout` [bad-argument-type]
--> tests/unit_tests/tasks/test_human_input_timeout_tasks.py:119:43
+ERROR Object of class `Task` has no attribute `queue` [missing-attribute]
+ --> tests/unit_tests/tasks/test_initialize_created_app_rbac_access_task.py:11:12
ERROR No matching overload found for function `python_http_client.exceptions.HTTPError.__init__` called with arguments: (MagicMock, Literal['Unauthorized']) [no-matching-overload]
--> tests/unit_tests/tasks/test_mail_send_task.py:656:83
ERROR No matching overload found for function `python_http_client.exceptions.HTTPError.__init__` called with arguments: (MagicMock, Literal['Forbidden']) [no-matching-overload]
|
Contributor
Pyrefly Type Coverage
|
GareArc
force-pushed
the
cherry-pick/38911-rbac-perm
branch
from
July 14, 2026 10:30
48625c8 to
ee189b5
Compare
GareArc
changed the base branch from
hotfix/1.15.0-fix.10
to
hotfix/1.15.0-fix.11
July 14, 2026 10:36
GareArc
force-pushed
the
cherry-pick/38911-rbac-perm
branch
from
July 14, 2026 10:47
06ad3bf to
06b268e
Compare
fatelei
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize_created_app_rbac_access_task), since feat: when knowledge permission is all team need update rbac setttings #38911 builds on it and it wasn't present on this branch.packages/contracts/generated/api/console/workspaces/{types,zod}.gen.tsafter conflict resolution to match actual Flask-RESTX route models._add_tenant_account_join) left over from conflict resolution that referenced unimported types and was never called.Test plan
pyteston RBAC/account/app-response/task unit tests: 509 passedruff check .cleanpnpm gen-api-contractre-run to verify generated contracts match backend route models