Skip to content

fix: sync RBAC whitelist when dataset permission is set to all team - #38952

Merged
GareArc merged 2 commits into
hotfix/1.15.0-fix.11from
cherry-pick/38911-rbac-perm
Jul 14, 2026
Merged

fix: sync RBAC whitelist when dataset permission is set to all team#38952
GareArc merged 2 commits into
hotfix/1.15.0-fix.11from
cherry-pick/38911-rbac-perm

Conversation

@GareArc

@GareArc GareArc commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • pytest on RBAC/account/app-response/task unit tests: 509 passed
  • ruff check . clean
  • pnpm gen-api-contract re-run to verify generated contracts match backend route models

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-07-14 10:48:33.093966064 +0000
+++ /tmp/pyrefly_pr.txt	2026-07-14 10:48:24.582908128 +0000
@@ -6854,6 +6854,8 @@
    --> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:760:71
 ERROR `in` is not supported between `Literal['not found']` and `None` [not-iterable]
    --> tests/unit_tests/services/retention/workflow_run/test_restore_archived_workflow_run.py:907:16
+ERROR Argument `SimpleNamespace` is not assignable to parameter `session` with type `Session` in function `services.account_service.TenantService.iter_member_account_id_batches` [bad-argument-type]
+   --> tests/unit_tests/services/test_account_service.py:693:81
 ERROR Argument `_FakeWriteSession` is not assignable to parameter `session` with type `scoped_session[Unknown]` in function `services.agent_app_feature_service.AgentAppFeatureConfigService.update_features` [bad-argument-type]
    --> tests/unit_tests/services/test_agent_app_feature_service.py:102:21
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
@@ -7612,6 +7614,8 @@
    --> tests/unit_tests/tasks/test_human_input_timeout_tasks.py:117:43
 ERROR Argument `SimpleNamespace` is not assignable to parameter `form_model` with type `HumanInputForm` in function `tasks.human_input_timeout_tasks._is_global_timeout` [bad-argument-type]
    --> tests/unit_tests/tasks/test_human_input_timeout_tasks.py:119:43
+ERROR Object of class `Task` has no attribute `queue` [missing-attribute]
+  --> tests/unit_tests/tasks/test_initialize_created_app_rbac_access_task.py:11:12
 ERROR No matching overload found for function `python_http_client.exceptions.HTTPError.__init__` called with arguments: (MagicMock, Literal['Unauthorized']) [no-matching-overload]
    --> tests/unit_tests/tasks/test_mail_send_task.py:656:83
 ERROR No matching overload found for function `python_http_client.exceptions.HTTPError.__init__` called with arguments: (MagicMock, Literal['Forbidden']) [no-matching-overload]

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 51.41% 51.41% -0.00%
Strict coverage 50.92% 50.92% -0.00%
Typed symbols 30,678 30,687 +9
Untyped symbols 29,270 29,280 +10
Modules 2933 2935 +2

@GareArc
GareArc force-pushed the cherry-pick/38911-rbac-perm branch from 48625c8 to ee189b5 Compare July 14, 2026 10:30
@GareArc
GareArc changed the base branch from hotfix/1.15.0-fix.10 to hotfix/1.15.0-fix.11 July 14, 2026 10:36
@GareArc
GareArc requested a review from fatelei July 14, 2026 10:38
fatelei and others added 2 commits July 14, 2026 03:46
…38636)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 7e05f28)
#38911)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit c278148)
@GareArc
GareArc force-pushed the cherry-pick/38911-rbac-perm branch from 06ad3bf to 06b268e Compare July 14, 2026 10:47
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 14, 2026
@GareArc
GareArc merged commit be737a3 into hotfix/1.15.0-fix.11 Jul 14, 2026
5 checks passed
@GareArc
GareArc deleted the cherry-pick/38911-rbac-perm branch July 14, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants