Skip to content

test: use SQLite sessions in web controller fixtures - #39052

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
asukaminato0721:split/sqlite-unit-006-web-controller-fixtures
Aug 3, 2026
Merged

test: use SQLite sessions in web controller fixtures#39052
asukaminato0721 merged 1 commit into
langgenius:mainfrom
asukaminato0721:split/sqlite-unit-006-web-controller-fixtures

Conversation

@asukaminato0721

@asukaminato0721 asukaminato0721 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Split 006 of 077 from #38784. This PR scopes the SQLite-session migration to web controller fixtures.

Files

  • api/tests/unit_tests/controllers/web/conftest.py
  • api/tests/unit_tests/controllers/web/test_web_passport.py

Authored scope

  • 215 changed lines (95 additions, 120 deletions)
  • 2 files

Temporary upstream autofix

The upstream autofix.ci workflow adds dify-agent-runtime/README.md (6 additions, 6 deletions) to every API PR. That shared bot diff will disappear here after #38784 merges.

Validation

  • Ruff passed for every changed Python file in the split series
  • Target tests passed independently: api/tests/unit_tests/controllers/web/test_web_passport.py
  • Full split-series run: 2122 passed

Part of #32454

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 57.30% 57.29% -0.01%
Strict coverage 56.83% 56.82% -0.01%
Typed symbols 37,552 37,537 -15
Untyped symbols 28,218 28,217 -1
Modules 3091 3091 0

@asukaminato0721
asukaminato0721 marked this pull request as ready for review July 16, 2026 06:06
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 16, 2026
Comment thread api/tests/unit_tests/controllers/web/test_web_passport.py Outdated
@asukaminato0721
asukaminato0721 force-pushed the split/sqlite-unit-006-web-controller-fixtures branch from 72d312a to f4d4e44 Compare August 2, 2026 13:56
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 2, 2026
@asukaminato0721
asukaminato0721 force-pushed the split/sqlite-unit-006-web-controller-fixtures branch from f4d4e44 to 13a6340 Compare August 3, 2026 03:36
@asukaminato0721
asukaminato0721 requested a review from 41tair August 3, 2026 03:36
@asukaminato0721
asukaminato0721 added this pull request to the merge queue Aug 3, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 3, 2026
Merged via the queue into langgenius:main with commit 7307944 Aug 3, 2026
34 checks passed
@asukaminato0721
asukaminato0721 deleted the split/sqlite-unit-006-web-controller-fixtures branch August 3, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants