test: use SQLite sessions in controllers service api - #39059
Merged
asukaminato0721 merged 3 commits intoAug 3, 2026
Merged
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-08-03 03:07:25.500978850 +0000
+++ /tmp/pyrefly_pr.txt 2026-08-03 03:07:14.438881750 +0000
@@ -2300,6 +2300,14 @@
--> tests/unit_tests/controllers/openapi/test_workspaces_members.py:209:12
ERROR `in` is not supported between `Literal['PATCH']` and `None` [not-iterable]
--> tests/unit_tests/controllers/openapi/test_workspaces_members.py:210:12
+ERROR Object of class `FromClause` has no attribute `delete` [missing-attribute]
+ --> tests/unit_tests/controllers/service_api/app/test_app.py:90:17
+ERROR Argument `list[FromClause]` is not assignable to parameter `tables` with type `Sequence[Table] | None` in function `sqlalchemy.sql.schema.MetaData.create_all` [bad-argument-type]
+ --> tests/unit_tests/controllers/service_api/app/test_app.py:135:56
+ERROR Returned type `AppDatabase` is not assignable to declared return type `Iterator[AppDatabase]` [bad-return]
+ --> tests/unit_tests/controllers/service_api/app/test_app.py:268:12
+ERROR Object of class `FromClause` has no attribute `delete` [missing-attribute]
+ --> tests/unit_tests/controllers/service_api/app/test_app.py:418:29
ERROR Cannot index into `Iterable[bytes]` [bad-index]
--> tests/unit_tests/controllers/service_api/app/test_audio.py:191:16
ERROR Cannot index into `Response` [bad-index]
|
Contributor
Pyrefly Type Coverage
|
asukaminato0721
marked this pull request as ready for review
July 16, 2026 06:06
asukaminato0721
requested review from
QuantumGhost,
crazywoola and
laipz8200
as code owners
July 16, 2026 06:06
Member
|
we need cover full user_input_form and session assertions, add zero multiple-tag cases. |
41tair
requested changes
Jul 30, 2026
41tair
left a comment
Member
There was a problem hiding this comment.
we need cover full user_input_form and session assertions, add zero multiple-tag cases.
Depends on langgenius#38784. Part of langgenius#32454.
asukaminato0721
force-pushed
the
split/sqlite-unit-013-controllers-service-api
branch
from
August 2, 2026 13:48
c1b5909 to
ef99f4a
Compare
asukaminato0721
enabled auto-merge
August 3, 2026 03:01
41tair
approved these changes
Aug 3, 2026
asukaminato0721
deleted the
split/sqlite-unit-013-controllers-service-api
branch
August 3, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split 013 of 077 from #38784. This PR scopes the SQLite-session migration to controllers service api.
Files
api/tests/unit_tests/controllers/service_api/app/test_app.pyAuthored scope
Temporary upstream autofix
The upstream
autofix.ciworkflow addsdify-agent-runtime/README.md(6 additions, 6 deletions) to every API PR. That shared bot diff will disappear here after #38784 merges.Dependency
Depends on #38784. The target tests passed with that foundation applied; this branch stays based on
mainso its authored diff remains minimal.Validation
api/tests/unit_tests/controllers/service_api/app/test_app.pyPart of #32454