fix(web): improve DSL export feedback#39409
Merged
Merged
Conversation
lyzno1
enabled auto-merge
July 22, 2026 09:30
lyzno1
marked this pull request as draft
July 22, 2026 09:32
auto-merge was automatically disabled
July 22, 2026 09:32
Pull request was converted to draft
lyzno1
marked this pull request as ready for review
July 22, 2026 09:34
lyzno1
enabled auto-merge
July 22, 2026 09:34
iamjoel
approved these changes
Jul 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39409 +/- ##
=======================================
Coverage 85.82% 85.83%
=======================================
Files 4999 5000 +1
Lines 279716 279731 +15
Branches 54955 54970 +15
=======================================
+ Hits 240073 240097 +24
+ Misses 34935 34926 -9
Partials 4708 4708
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DSL exports could appear idle while requests were pending. Workflow callers also fetched the full draft only to inspect secret environment variables, while Agent v2 does not use workflow drafts.
User impact
Users now get immediate loading feedback and duplicate export requests are prevented. Workflow exports only read the smaller environment-variable endpoint before deciding whether secret confirmation is required.
Validation
cd web && vp test run app/components/app/__tests__/use-export-app-dsl.spec.tsx app/components/apps/__tests__/app-card.spec.tsx app/components/app-sidebar/app-info/__tests__/use-app-info-actions.spec.ts app/components/app-sidebar/app-info/__tests__/app-info-detail-panel.spec.tsx app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx features/agent-v2/roster/components/__tests__/agent-roster-list.spec.tsx features/agent-v2/agent-detail/__tests__/navigation.spec.tsx app/components/workflow/__tests__/dsl-export-confirm-modal.spec.tsxcd web && pnpm type-checkcd packages/dify-ui && vp test run --project unit src/toast/__tests__/index.spec.tsxcd packages/dify-ui && vp test --project storybook --run src/toast/index.stories.tsxcd packages/dify-ui && pnpm type-checkgit diff --check