fix: replace generated column with partial unique index for PG logical replication - #39473
Open
rkfshakti wants to merge 4 commits into
Open
fix: replace generated column with partial unique index for PG logical replication#39473rkfshakti wants to merge 4 commits into
rkfshakti wants to merge 4 commits into
Conversation
rkfshakti
requested review from
MRZHUH,
QuantumGhost,
laipz8200 and
snakevash
as code owners
July 23, 2026 16:19
dosubot
Bot
added
the
size:M
Contributor
Pyrefly Type Coverage
|
rkfshakti
commented
Jul 23, 2026
rkfshakti
left a comment
rkfshakti
left a comment
Contributor
Author
There was a problem hiding this comment.
please review to share feedback, this should be resolved now.
Contributor
Author
|
Friendly ping — this PR has been open for a few days with CI passing. The fix replaces a generated column on the agents table with a partial unique index so PostgreSQL logical replication doesn't fail with InvalidColumnReference. As @crazywoola noted on #39472, there's an overlapping migration file between these two PRs — I'm happy to consolidate them into a single PR if that's preferred. Let me know how you'd like to proceed. |
fatelei
approved these changes
Jul 27, 2026
…l replication The agents table had a STORED GENERATED column (roster_unique_name) in a UniqueConstraint. When PostgreSQL has wal_level=logical (logical replication enabled), it tries to use this unique constraint for replica identity tracking, but generated columns cannot be published, causing: InvalidColumnReference: cannot update table 'agents' DETAIL: Replica identity must not contain unpublished generated columns. Replace the generated column + unique constraint with a partial unique index on (tenant_id, name) WHERE scope='roster' AND status='active'. This achieves the same uniqueness guarantee without a generated column. Fixes langgenius#39460
… column The tests were still checking for the old UniqueConstraint (agents_tenant_id_key) and the roster_unique_name generated column, which were replaced with a partial unique index to fix PostgreSQL logical replication conflicts. Update test_agent_table_uses_partial_unique_index_for_active_roster_names to verify the new partial unique index (agents_tenant_id_active_roster_name_key) with its postgresql_where condition. Update test_active_roster_agent_name_unique_constraint_allows_archived_and_workflow_only_duplicates to verify the schema definition instead of runtime enforcement, since SQLite does not support postgresql_where partial indexes.
ColumnCollection does not compare equal to a plain tuple, causing AssertionError. Use the same tuple(column.name ...) pattern as the roster index assertion.
rkfshakti
force-pushed
the
fix/pg-logical-replication-39460
branch
from
July 27, 2026 01:52
b0f18b2 to
8dfa12c
Compare
Contributor
Author
|
Hi maintainers — following up again on this fix for #39460. Replaces the generated column with a partial unique index for PostgreSQL logical replication compatibility. CI is passing. Would appreciate a review when time allows. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PostgreSQL has wal_level=logical (logical replication enabled), the agents table's STORED GENERATED column (roster_unique_name) in a UniqueConstraint causes:
InvalidColumnReference: cannot update table 'agents'
DETAIL: Replica identity must not contain unpublished generated columns.
Replace the generated column + unique constraint with a partial unique index on (tenant_id, name) WHERE scope='roster' AND status='active'. This achieves the same uniqueness guarantee without a generated column.
Fixes #39460