fix(workflow): persist Agent caller before node execution - #39699
Open
zyz619963502zyz wants to merge 3 commits into
Open
fix(workflow): persist Agent caller before node execution#39699zyz619963502zyz wants to merge 3 commits into
zyz619963502zyz wants to merge 3 commits into
Conversation
…thub.com/langgenius/dify into fix/workflow-start-persistence-order
…persistence-order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39546.
Graphon 0.6.0 runs layer
on_node_run_starthooks synchronously in the worker beforenode.run()can advance. This change uses that boundary for Agent v2 to commit itsWorkflowNodeExecutionModelcaller row before participant/session setup begins.WorkflowPersistenceLayer.on_node_run_startNodeRunStartedEventreaches the dispatcher instead of inserting it againDifyAgentNode, before binding resolution or participant allocationNon-Agent nodes retain the existing event-driven persistence path.
Tests
pytest api/tests/unit_tests/core/app/workflow/test_persistence_layer.py api/tests/unit_tests/core/workflow/nodes/agent_v2/test_agent_node.py api/tests/unit_tests/core/workflow/nodes/agent_v2/test_session_store.py -q— 66 passedpy_compileon production modulesgit diff --checkThe new tests deterministically cover both the worker-first ordering and persistence failure before participant allocation; no sleeps or timing polls are used.