fix(web): notify parent on MCP OAuth callback when opener is missing - #39763
Draft
Souravrajvi0 wants to merge 1 commit into
Draft
fix(web): notify parent on MCP OAuth callback when opener is missing#39763Souravrajvi0 wants to merge 1 commit into
Souravrajvi0 wants to merge 1 commit into
Conversation
The oauth-callback page only posted a message when window.opener was available. After cross-origin OAuth redirects, browsers can drop the opener reference, leaving users on a blank page. Add BroadcastChannel fallback delivery, deduplicate popup callbacks, show success/error feedback on the callback page, and cover the flow with unit tests. Fixes langgenius#39752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #39752
After MCP OAuth authorization completes, the backend redirects to
/oauth-callback. The callback page previously rendered an empty<div />and only notified the parent console window whenwindow.openerwas available. After cross-origin OAuth redirects (e.g. Notion MCP), browsers can drop the opener reference, leaving users on a blank page and preventing the console from refreshing authorization state.This change:
BroadcastChannelfallback so the parent window still receives the OAuth completion event whenwindow.openeris missingpostMessageandBroadcastChannelfireRoot cause
useOAuthCallbackgated all parent notification and window closing behindif (window.opener). When the opener reference is lost during the OAuth redirect chain, the hook did nothing and the page rendered an empty container.Impact
openOAuthPopup//oauth-callback) now reliably notify the console even whenwindow.openeris unavailableScreenshots
N/A for automated VM validation — requires live OAuth provider redirect.
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation