fix(dify-agent): retry E2B Shellctl connects in transport - #39879
Draft
zhaohao1004 wants to merge 1 commit into
Draft
fix(dify-agent): retry E2B Shellctl connects in transport#39879zhaohao1004 wants to merge 1 commit into
zhaohao1004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
An E2B Sandbox may be connectable through the control plane before its Shellctl endpoint is ready to accept a TCP/TLS connection. A first data-plane request can therefore fail with
ConnectErrororConnectTimeoutduring resume startup.Retrying the complete Shell adapter operation would re-enter the logical request and can expand its timeout. Connection readiness retries belong at the HTTP transport boundary instead.
Implementation
AsyncClientwithAsyncHTTPTransport(retries=2)Impact
E2B Shellctl connections receive up to two additional connection attempts during transient startup races. Read failures, HTTP responses, and accepted Shell jobs are not retried.
Transport retries use per-connection timeouts; this change does not add a hard wall-clock deadline around the complete operation.
Validation
make -C dify-agent checkScope
This PR changes only the E2B Runtime backend and its focused test. It contains no Config Layer changes and is independent of #39873.
From Codex