test(api): make session decorator path assertion platform-agnostic - #39895
Open
AlexMultiAgent wants to merge 1 commit into
Open
test(api): make session decorator path assertion platform-agnostic#39895AlexMultiAgent wants to merge 1 commit into
AlexMultiAgent wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(api): make session decorator path assertion platform-agnostic
Fixes #39890
Summary
co_filenamebefore comparing it intest_post_uses_one_session_and_rolls_back_when_signal_failsso the decorator unwrap loop terminates on Windows as well as POSIX.Root cause
The test walks the decorator chain with
co_filename.endswith("controllers/common/session.py"). On Windowsco_filenamecontains backslashes, so the condition never matches and the loop unwraps past the end of the chain, raisingAttributeError: 'function' object has no attribute '__wrapped__'. The chain itself is intact.Validation
test_model_config_api.pypasses on POSIX as well.Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Codex