Skip to content

fix(api): align marketplace download-url references in unit test and e2e helpers - #39898

Open
AlexMultiAgent wants to merge 1 commit into
langgenius:mainfrom
AlexMultiAgent:fix/marketplace-download-url-references
Open

fix(api): align marketplace download-url references in unit test and e2e helpers#39898
AlexMultiAgent wants to merge 1 commit into
langgenius:mainfrom
AlexMultiAgent:fix/marketplace-download-url-references

Conversation

@AlexMultiAgent

Copy link
Copy Markdown

fix(api): align marketplace download-url references in unit test and e2e helpers

Fixes #39892

Summary

  • Assert the exact renamed endpoint in test_get_plugin_pkg_url_contains_unique_identifier and add a negative assertion for the old path.
  • Update the E2E marketplace seed helper to download from /api/v1/plugins/download-url.
  • Update the E2E test fixture message to the new URL; the fallback matcher still matches both old and new error text.

Root cause

PR #39811 renamed the backend marketplace download URL from /api/v1/plugins/download to /api/v1/plugins/download-url but did not update the E2E seed helper or the backend unit test. The unit test kept passing only because the new path contains the old path as a substring.

Validation

  • Backend: test_marketplace.py passes and now pins the exact path.
  • E2E: marketplace-plugins.test.ts still exercises the fallback branch with the updated fixture.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

From Codex

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 2, 2026
@github-actions github-actions Bot added the e2e End-to-end tests and E2E test infrastructure. label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e End-to-end tests and E2E test infrastructure. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] E2E seed helpers and a unit test still reference the old /api/v1/plugins/download endpoint after it was renamed to /download-url

1 participant