Improve error handling resilience across extractors and parsers - #39945
Open
DhanushPillay wants to merge 5 commits into
Open
Improve error handling resilience across extractors and parsers#39945DhanushPillay wants to merge 5 commits into
DhanushPillay wants to merge 5 commits into
Conversation
…he internal proxy to prevent local network scanning
Added a max page limit to Notion extractor to prevent infinite pagination loops. Improved the output moderation log to clarify that content passes through when the service fails. Replaced a bare except in the CoT parser with specific exceptions to prevent swallowing system signals. Added a warning log for tool provider credential parsing failures to aid debugging.
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39944
This PR addresses four independent error handling oversights in the core API to improve backend resilience and observability:
max_pages = 1000limit to the Notion extractor to prevent infinite pagination loops.except:in the CoT parser with(json.JSONDecodeError, ValueError)to prevent swallowing system signals.