fix(web): make tool category filters keyboard accessible - #40243
Draft
lyzno1 wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-pressedstateSemantic contract
This selector filters a tool collection; it does not own tab panels. Dify UI documents SegmentedControl for mode, filter, and view selection without tabpanel semantics, so this PR intentionally does not misuse the Tabs primitive.
data-testidattributes remain for compatibility; behavior tests use role, name, and stateScope
No panel, query, routing, or filtering implementation changes.
Test evidence
The updated test failed first because the old implementation exposed no accessible group or buttons. It now verifies:
aria-pressedstateFocused result: 1/1 passed.
Visual regression
Compared the Storybook story against #40242 with the same viewport and theme.
Visual builderremains at (565.156, 368.5), andCoderemains at (702.227, 368.5)Verification
pnpm exec vp test run app/components/base/tab-slider-new/__tests__/index.spec.tsx— 1/1vp check— 0 errorsnode scripts/lint-a11y.mjs app/components/base/tab-slider-new/index.tsx app/components/integrations/tool-provider-toolbar.tsxpnpm lint:oxlint --prune-suppressionspnpm check— 0 errors, existing warnings onlygit diff --checkStack
Base: #40242
Child: #40244 is a Storybook-only CSS icon cleanup. This production behavior layer can be reviewed and reverted independently.