fix(web): use button for chat variable panel close - #40333
Queued
lyzno1 wants to merge 3 commits into
Queued
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40333 +/- ##
==========================================
- Coverage 86.47% 86.42% -0.05%
==========================================
Files 5264 5107 -157
Lines 294867 290741 -4126
Branches 59029 57924 -1105
==========================================
- Hits 254976 251287 -3689
+ Misses 34950 34513 -437
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
force-pushed
the
codex/a11y-chat-variable-panel-close
branch
from
August 9, 2026 14:31
946e714 to
6a4fd21
Compare
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
hjlarry
approved these changes
Aug 10, 2026
lyzno1
added this pull request to the merge queue
Aug 10, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
divwith a nativebutton type="button"Ownership and scope
This layer changes only the Conversation Variables panel close action. Variable CRUD, collaboration events, modal behavior, panel dimensions, and the adjacent tips control are unchanged. It is the root of this same-owner stack and can merge independently.
Validation
pnpm --dir web exec vp test run app/components/workflow/panel/chat-variable-panel/__tests__/index.spec.tsx— 4/4 passedpnpm --dir web lint:a11y 'app/components/workflow/panel/chat-variable-panel/index.tsx'— passedpnpm check— 0 errors / 2059 existing warningsgit diff --check— passedVisual regression review
Expected visual delta: none in pointer interaction; a native keyboard focus indicator is expected.
Please verify:
The button keeps the former 24×24 flex geometry. Explicit
border-0,bg-transparent,p-0, andappearance-noneisolate native button chrome without changing the normal state.Rollback
Revert this PR alone. The two higher layers are optional refinements and do not change this close handler.
Final visual guard
The converted native button now also uses
appearance-none, closing the remaining cross-browser UA appearance path while preserving the existing normal-state geometry and tokens.