Skip to content

fix(web): name chat settings triggers - #40341

Merged
lyzno1 merged 1 commit into
mainfrom
codex/a11y-chat-settings-triggers
Aug 10, 2026
Merged

fix(web): name chat settings triggers#40341
lyzno1 merged 1 commit into
mainfrom
codex/a11y-chat-settings-triggers

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • give both ViewFormDropdown triggers the existing localized View chat settings name
  • hide each glyph from the accessibility tree
  • query both chat surfaces by role and accessible name
  • verify the Base UI popover transition through aria-expanded
  • keep the ActionButton content model valid with an inline span

Review boundary

This is one duplicated user-facing contract across chat-with-history and embedded-chatbot. Form fields, validation, submission, popover ownership, handlers, classes, and layout are unchanged. The unused test id removed from the touched trigger is not replaced.

Verification

  • two owner suites: 4/4 passed
  • standalone a11y lint on both production files: 0 diagnostics
  • full static check: 0 errors
  • diff check: passed

Visual regression review

Only ARIA attributes and an inline div-to-span content-model correction change in production. Geometry, icons, alignment, placement, hover, and open states remain unchanged.

Dependency and rollback

Independent root layer and sole owner of these two trigger names.

@lyzno1 lyzno1 changed the title codex/a11y chat settings triggers fix(web): name chat settings triggers Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (56bfe8b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40341      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.04%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290742    -4125     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251293    -3683     
+ Misses      34950    34508     -442     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 force-pushed the codex/a11y-chat-settings-triggers branch from 393258d to 56bfe8b Compare August 9, 2026 13:47
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit f8d381e Aug 10, 2026
62 of 70 checks passed
@lyzno1
lyzno1 deleted the codex/a11y-chat-settings-triggers branch August 10, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants