fix(web): name chat settings triggers - #40341
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40341 +/- ##
==========================================
- Coverage 86.47% 86.43% -0.04%
==========================================
Files 5264 5107 -157
Lines 294867 290742 -4125
Branches 59029 57924 -1105
==========================================
- Hits 254976 251293 -3683
+ Misses 34950 34508 -442
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
force-pushed
the
codex/a11y-chat-settings-triggers
branch
from
August 9, 2026 13:47
393258d to
56bfe8b
Compare
This was referenced Aug 9, 2026
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
lyzno1
requested review from
CodingOnStar,
hyoban,
iamjoel and
zxhlyh
as code owners
August 9, 2026 15:47
hjlarry
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review boundary
This is one duplicated user-facing contract across chat-with-history and embedded-chatbot. Form fields, validation, submission, popover ownership, handlers, classes, and layout are unchanged. The unused test id removed from the touched trigger is not replaced.
Verification
Visual regression review
Only ARIA attributes and an inline div-to-span content-model correction change in production. Geometry, icons, alignment, placement, hover, and open states remain unchanged.
Dependency and rollback
Independent root layer and sole owner of these two trigger names.