Skip to content

Fix/http node params#4401

Closed
Wang-HL wants to merge 36 commits into
langgenius:deploy/devfrom
Wang-HL:fix/http-node-params
Closed

Fix/http node params#4401
Wang-HL wants to merge 36 commits into
langgenius:deploy/devfrom
Wang-HL:fix/http-node-params

Conversation

@Wang-HL

@Wang-HL Wang-HL commented May 15, 2024

Copy link
Copy Markdown
Contributor

Description

When I expect to add a key-value value in the PARAMS on the HTTP Node, such as key: 'url' and value: 'http://xxxx.com', I find that when I close the edit box and reopen the edit box, the value becomes http, and the content after ':' will be lost.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Enter key: 'url' and value: 'http://xxxx.com' in the PARAMS of the http node. Close the edit drawer and reopen it. The content of the value will not change.

  • TODO key has same issue

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

YidaHu and others added 30 commits May 11, 2024 10:07
Co-authored-by: 陈力坤 <likunchen@caixin.com>
Co-authored-by: crazywoola <427733928@qq.com>
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. 🐞 bug Something isn't working labels May 15, 2024
@Yeuoly

Yeuoly commented May 15, 2024

Copy link
Copy Markdown
Contributor

hi, looks like there are lots of irrelevant changes in this PR, pls rebase to main, thx!

@Wang-HL Wang-HL closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.